Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MultipartBody filename #213

Merged

Conversation

ricardoboss
Copy link
Contributor

Fixes #212.

This adds a class to hold information about a part added to a MultipartBody. In addition to that, it is now possible to pass a file name to the AddOrReplacePart method, that will be added to the Content-Disposition header when serializing.

@ricardoboss
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ricardoboss

Could you please bump the version number in the csproj file as well as add a changelog entry to the Changelog.md file at the repository root?

@ricardoboss ricardoboss requested a review from a team as a code owner March 26, 2024 14:47
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ricardoboss

@andrueastman andrueastman enabled auto-merge March 26, 2024 15:07
@andrueastman andrueastman merged commit 9852c37 into microsoft:main Mar 26, 2024
7 checks passed
@ricardoboss ricardoboss deleted the issues/212-multipart-body-filename branch March 26, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Multipart body is missing the ability to add a filename
2 participants